Merged
Conversation
affeldt-aist
changed the title
affeldt-aist
force-pushed
the
ereal_pseudometric
branch
from
c96cd2d to
1c8889a
Compare
CohenCyril
reviewed
May 29, 2020
affeldt-aist
force-pushed
the
ereal_pseudometric
branch
from
7a62289 to
9d4c2ce
Compare
CohenCyril
reviewed
May 31, 2020
CohenCyril
reviewed
Jun 2, 2020
affeldt-aist
force-pushed
the
ereal_pseudometric
branch
from
86aa1ce to
572d272
Compare
affeldt-aist
force-pushed
the
ereal_pseudometric
branch
from
572d272 to
ae0f332
Compare
affeldt-aist
force-pushed
the
ereal_pseudometric
branch
from
ae0f332 to
ff2de7d
Compare
CohenCyril
reviewed
Jun 9, 2020
CohenCyril
reviewed
Jun 9, 2020
CohenCyril
reviewed
Jun 9, 2020
affeldt-aist
force-pushed
the
ereal_pseudometric
branch
from
bcf7815 to
861a90d
Compare
CohenCyril
approved these changes
Jun 10, 2020
Member
CohenCyril
left a comment
CohenCyril
left a comment
There was a problem hiding this comment.
LGTM, the proofs look a bit long to me, but we can refactor later!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warning:
- PR based on PR Supremums ereal #203(has been merged into master)